2009/5/21 Evan Martin <[email protected]> > I could make git-cl track what your patch was last uploaded against, > and warn on dcommit if that upload was not based on an upstream svn > commit. That would be pretty easy: > - on upload, stuff the diff base into a property of the branch > - on dcommit, call something like "git cat-file -p DIFFBASE | egrep > -q ^git-svn-id:" > > I seem to recall Paweł sending me a patch to do something like #1 but > it's probably buried in my inbox somewhere... :\ > > On Thu, May 21, 2009 at 10:34 AM, Marc-Antoine Ruel <[email protected]> > wrote: > > [+chromium-dev] > > Well, the plain old: > > If "diff of stuff being committed" != "diff of codereview" > > Error -> "You are trying to commit code that is different from what you > > reviewed." > > Note that this applies to svn too. I think I could implement that on a > > PRESUBMIT script. I'm just afraid it'd slow down the commit. :/ One > thing > > to help would be to cache the diff on upload. > > M-A >
Ok we're saying the same thing. I agree it doesn't belong to PRESUBMIT at all and should be implemented in git-cl/gcl instead. M-A --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
