On Wed, May 27, 2009 at 11:56 AM, Amanda Walker <[email protected]> wrote:
> I'd be much happier if DCHECK exited immediately rather than relying on the > code to crash, or we insisted that code using DCHECK *always* attempt to > recover. > Yeah, it seems that relying on the code to crash by itself after a DCHECK is unreliable. It might crash, or it might just do some truly random things (wiping out preferences or URLs or any other persistent data) that the user might not notice until it was too late, not to mention security holes (well, I guess Amanda already mentioned them :). I think that after a DCHECK you should either recover completely (which is probably not possible unless the DCHECK could be replaced by some automatic recovery code anyhow) or crash so we get some info as to why it happened. -Greg. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
