Hi, Thanks for review. 2009/6/25 Jeremy Orlow <jor...@chromium.org>
> I only skimmed, but it looks well thought out. > One question though: > is this going to be functional for non-Chromium browsers? Given that your > design doc mentions v8 and hooks into Chromium's network > stack, but no mention of JavaScriptCore or WebKit's resource loading code, > I'm worried that the answer is no. > > I strongly recommend that your design doc include details for full > integration into "normal" WebKit and that you offer to write the necessary > code. If it's Chromium only, you'll definitely get more push back on the > design and people will be less willing to review. Probably to the extent > that it would have been easier to just write the code to begin with. > v8 and hooks into chromium's network stack was written in chromium part only. I planed to send webkit part to webkit-dev. I've mentioned what platform code is required in WebSocketHandle in webkit part design doc. I just added JavaScript binding section. Do we need more detailed information for these part? Thanks, ukai > J > > On Wed, Jun 24, 2009 at 2:32 AM, Fumitoshi Ukai (鵜飼文敏) > <u...@chromium.org>wrote: > >> Hi, >> >> yuzo, tyoshino and I start working to implement HTML5 Web Socket and write >> design docs >> >> WebKit part: http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh >> Chromium part: http://docs.google.com/View?id=dfm7gfvg_1dm97qxgm >> >> We'll send WebKit part to webkit-dev, if it looks ok. >> We'd welcome if you could give us feedback on our design docs. >> >> Thanks, >> ukai >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
