You should look at what the windows impl does. It probably goes directly to the themes system and tells it to reset, without involving extensions.
However.... Glen, now that we have extension uninstall implemented, I feel like we should integrate these two better. There should be (low-priority) todos for: * On theme switch, uninstall any previous theme extension * On extension uninstall, if it is a theme, revert to the default theme * In the prefs pane, call ExtnesionsService::UninstallExtension() instead of whatever we're currently doing - a On Wed, Jul 15, 2009 at 9:16 AM, Avi Drissman<[email protected]> wrote: > Ahh... So there needs to be a reset button in prefs. I can look it up, but > does it just uninstall all theme extensions? > > Deleting a theme from the extensions page does leave stuff behind. > > Avi > > On Wed, Jul 15, 2009 at 12:03 PM, Glen Murphy <[email protected]> wrote: >> >> There is no theme management - there is a 'reset to default' button in >> options, and that's it. 'Management' is done by using the themes site >> and reinstalling from there. Users should never see the word >> 'extension' if all they care about is themes, at least for 3.0. >> >> >> >> On Wed, Jul 15, 2009 at 8:15 AM, Avi Drissman<[email protected]> wrote: >> > On Wed, Jul 15, 2009 at 11:09 AM, Erik Kay <[email protected]> wrote: >> >> >> >> On Wed, Jul 15, 2009 at 7:44 AM, Avi Drissman <[email protected]> wrote: >> >>> >> >>> First, you said that you were going to make it so that when you >> >>> install >> >>> one theme it uninstalls all others. Is that coming soon? >> >> >> >> I don't know if that's the case. I believe the intention is that the >> >> theme stays installed, but simply that the app switches to use the new >> >> theme. Is this right Glen? >> > >> > So the old theme sits around unused. What happens when we uninstall the >> > current theme? Do we reinstall the older theme? Which older theme? >> > >> >> >> >> I assume you're talking about uninstalling the theme from >> >> chrome://extensions. >> > >> > Is there a different way to uninstall a theme? >> > >> >> >> >> On the other hand, I think Glen would prefer that we not show themes at >> >> all on chrome://extensions, which would reduce the need for this >> >> altogether >> >> (although it may still be a good idea for correctness). What do you >> >> think >> >> Glen? >> > >> > I think that themes might be technically extensions, but that they >> > should be >> > treated differently as they have different semantics than normal crxen >> > (only >> > one active at once, etc). We should have a list of "installed themes" so >> > the >> > user can switch between them. >> > >> >> >> >> I'd file a bug for the second, but punt on the first. >> > >> > Well, if I can find the cause for the second, I'll just fix it... >> > >> > Avi >> > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
