On Wed, Jul 22, 2009 at 9:15 PM, Mark Larson (Google) <[email protected]>wrote:
> > > On Wed, Jul 22, 2009 at 20:27, Dan Kegel <[email protected]> wrote: > >> >> Stop me if you've heard this one before. >> >> Today, a new directory was added to the source tree, and shortly >> thereafter was reverted. >> Should have been no problem, but... because the new directory >> contained a gyp file, a file was generated in that directory, >> and svn couldn't delete the directory when the revert landed. >> This caused a build breakage, and I gather from nsylvain's >> comments that this wasn't the first time this has happened. >> >> At some point soon, it'd be good to teach gyp not to generate >> files in the source tree. > > > Or maybe teach gclient how to deal forcefully with directories with no > files under version control. Generating files in the source tree is kinda > the point of gyp. > gclient has nothing to do with this case. "svn update src/" was trying to add a directory called "src/bleh", but "src/bleh" already existed, so "svn update" failed. The only thing gclient might want to do, is clobber your tree, and try again. We used to have stuff like that, but they are all disabled AFAIK, I lost too many important files because gclient wanted to be nice and clean up my machine. What we currently do, on the buildbot side, is clobber the source tree when something goes wrong with gclient. In this case it mostly worked, except on about 8 machines, where a file was locked. (No idea what it was, procexp was not helpful, closing all apps either. I had to reboot the machine) To answer dirk : Well, it needs manual cleanup. Ask a trooper to connect to each machine and fix them. (Or ask on irc, at this point about half of the team knows the passwords to the machines :| ). I guess we should formalize it more : "When in doubt, find someone to reboot the machine". It does not need any special skills, the machine will auto login and restart all the buildbot stuff automatically. Nicolas > > >> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
