On Wed, Jul 22, 2009 at 21:26, Dan Kegel <[email protected]> wrote: > On Thu, Jul 23, 2009 at 4:15 AM, Mark Larson (Google)<[email protected]> > wrote: > >> Should have been no problem, but... because the new directory > >> contained a gyp file, a file was generated in that directory, > >> and svn couldn't delete the directory when the revert landed. > >> This caused a build breakage, and I gather from nsylvain's > >> comments that this wasn't the first time this has happened. > >> > >> At some point soon, it'd be good to teach gyp not to generate > >> files in the source tree. > > > > Or maybe teach gclient how to deal forcefully with directories with no > files > > under version control. > > That's kind of, um, forceful. svn doesn't do that for a reason...
I was perhaps a bit too flip. I don't advocate automatic destruction of these directories, but it seems gclient could offer a mode/flag to clean them up. The build slaves will never have directories with un-versioned changes and could run gclient with this flag all the time. > > > > Generating files in the source tree is kinda the point of gyp. > > No. Generating files is the point of gyp. Nothing says they have to > be in the source tree. That is true. The real Mark has already responded to this better than I could. --other Mark > > - Dan > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
