Is there any reason you're doing this on appspot's code review, not chromium's? I reviewed half the patch at a high level. I think there's plenty of comments to address for now. Once those are addressed, I'm happy to take a deeper dive with the rest if there aren't any more qualified reviewers who'd like to take it on.
Even though this has been discussed to death, it might be good to still write up a mini-design doc since that's easier than code to review and I'm sure there's plenty of people who'd like to sanity check the design. (That said, I didn't see any major design flaws while reviewing.) J On Wed, Aug 5, 2009 at 4:52 PM, John Gregg <[email protected]> wrote: > Sorry, maybe not. It's a big world to keep up to date! Between WHATWG, > webkit-dev, and offline it's been discussed at some length at many levels, > but not much on this list as I check the archives. > > But in any case, while the code patch is large as I said I consider it > preliminary, and this is why I ask for feedback on the document (and the > design expressed in it) as well as the code. > > Thanks, > -John > > > On Wed, Aug 5, 2009 at 4:29 PM, Ben Goodger (Google) <[email protected]>wrote: > >> Has a design doc for this feature in general been sent around? This is >> a fairly large change otherwise. >> >> -Ben >> >> On Wed, Aug 5, 2009 at 4:13 PM, Evan Martin<[email protected]> wrote: >> > >> > On Wed, Aug 5, 2009 at 4:00 PM, Evan Martin<[email protected]> wrote: >> >> On Wed, Aug 5, 2009 at 3:51 PM, John Gregg<[email protected]> wrote: >> >>> As I mentioned to some of you offline, I would greatly appreciate a >> >>> "pre-review" so I can start to work out the issues and be as ready as >> >>> possible to check in once the WebKit process finishes. >> >> >> >> Looks promising, but I see Mac and Windows code and no Linux. ? >> > >> > To clarify, I'd at least like to see the design doc address how and >> > whether this will work on Linux. For example, suppose the APIs >> > available were more broad -- maybe then there is extra information >> > that ought to be plumbed around. >> > >> > > >> > >> > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
