On Thu, Aug 6, 2009 at 4:38 PM, Peter Kasting<[email protected]> wrote: >> i.e. Next time we hold a valgrind fixit, >> how about we just delete the non-upstream-bugs >> suppressions files? > > I think this would be a mistake. > There is a lot of accumulated "knowledge" in the valgrind suppresions file. > Doubtless some of it is obsolete (suppressions that no longer apply). > However, both erg and phajdan.jr have removed things like this (LayoutTest > cruft for erg) recently, and that can be done in a > change-one-variable-at-a-time controlled fashion. > By contrast, dumping the whole file would have two effects: > (1) If you're really serious about it, the tree will be closed for at least > several days. This is an extremely high cost. > (2) You will be getting intermittent red far more frequently for weeks as > the rarest of the suppressions in that file occasionally rear their head.
I forgot to mention: we would put the still-needed suppressions back after the fixit. There would be no ongoing flakiness as a result of the temporary deletion of the suppressions. Closing the tree for several days would be a low price to pay for cleaning up the flaky tests and valgrind leaks... - Dan --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
