On Tue, Aug 25, 2009 at 9:24 AM, Paweł Hajdan Jr. <[email protected]>wrote:
> I'm in the middle of debugging a problem which is caused by singletons. > It's a very bad category of problems, because the results are initially very > mysterious, until you discover that it's a singleton which carries state > from one test to another. > Browser tests carry a lot of state. The entire browser is started. So > browser_tests launcher makes sure that the test cases are well isolated (for > example it forks the process on Linux). > > However, I caught at least one case when IN_PROC_BROWSER_TESTS is used in > unit_tests binary. It works so far, but after adding more strict checks in > NotificationRegistrar (long story, I can explain if you wish) it breaks. > > I'm now preparing to move the file where it belongs: to browser_tests. > However, it would be nice to have a flag which would enable > IN_PROC_BROWSER_TEST only for browser_tests to prevent similar misuse. Like > -DENABLE_IN_PROC_BROWSER_TEST or similar. What do you think? > > +1 --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
