On Sun, Aug 30, 2009 at 8:57 PM, Nico Weber <[email protected]> wrote:
> I happened to look at a CL today that adds a "Really delete all > passwords?" dialog on Windows ( http://codereview.chromium.org/155291 > ). The patch was done by someone relatively new to the project (which > is of course great). Sadly, neither the patch author nor one of the > reviewers mentioned that this change might have to be done on the > other platforms as well. As it happens, it's not necessary on OS X, > but it might be required on Linux. I tried to poke my head in on that review early on and note that the proposed solution was not cross-platform, and that other platforms should be considered. It looks like subsequent discussion focused on trying to address that issue. Not sure what still remained to be done after the patch was committed as I didn't follow the patch any further. BTW, I'm uncomfortable with the UI design here. We normally eschew "are you sure?" dialogs since they're annoying when you _are_ sure, and frequently get (mis-)clicked-through even when you meant to do something else (because "make the dialog go away" is a learned action associated with hitting buttons in programs). It seems like it would have been far better to do something more akin to the Gmail action flow: delete all immediately, but then have some immediate way of undoing the action. CCing Ben, our UI lead, so if he likes the idea he can suggest I file a bug. PK --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
