+glen During that review I consulted Glen to see if we wanted such a dialog because I was unsure about it (like Peter), and he reported back to me with a green light from the UI team. As for multi-platform, password storage wasn't operational on other platforms at the time. There was some discussion about other platforms on the review, particularly about moving away from use of win_util in the original patch, and making something more generic similar to some JS popups we have. I don't think all[platforms]-or-nothing would have really fair to insist on :\ I don't think any person who wants to contribute to chromium should be required to have either a machine and/or skills required for each platform to test things out on, or be dedicated enough to have to solve everything instead of little chunks that they are immediately passionate about fixing; every little bit helps in my book. But I guess it isn't my book :) If we as a team feel otherwise I'll make sure to clamp down on it next time.
Could we just keep the bug<http://code.google.com/p/chromium/issues/detail?id=11401> (labelled "OS-All") open? On Tue, Sep 1, 2009 at 7:31 PM, Nick Baum <[email protected]> wrote: > Re:Peter's comment on this particular change, I think it's a rare enough > use case that having a dialog is fine. Users are likely to dismiss the > options window immediately after doing this, so it's not clear to me that an > undo function would be much better. > -Nick > > > On Sun, Aug 30, 2009 at 10:40 PM, Ben Goodger (Google) > <[email protected]>wrote: > >> >> From a UI design point of view, yes, but UI design is only one piece. >> Often times you benefit from having a platform expert who understands >> the underlying technology. >> >> -Ben >> >> On Sun, Aug 30, 2009 at 10:28 PM, PhistucK<[email protected]> wrote: >> > Since user interface changes (are supposed to) go by the user interface >> team >> > (some earlier thread required that), is it not part of their >> responsibility, >> > to answer cross platform questions such as this one? >> > ☆PhistucK >> > >> > >> > On Mon, Aug 31, 2009 at 08:00, Ben Goodger (Google) <[email protected]> >> > wrote: >> >> >> >> +1. It'd be good to involve experts from other platforms early in the >> >> process too even if the implementation is done later, so that the >> >> design considers local requirements. >> >> >> >> -Ben >> >> >> >> On Sun, Aug 30, 2009 at 9:44 PM, Mohamed Mansour<[email protected]> >> wrote: >> >> > I believe we should not close the tracker associated to the CL if a >> UI >> >> > tweak >> >> > should be done in all platforms, and its up to the developer to know >> who >> >> > to >> >> > delegate that task to. We shouldn't force anyone to develop this, we >> >> > should >> >> > properly tag the issue tracker and add proper labels. As well, we >> should >> >> > properly cc people who are more active in that platform, so they will >> >> > know >> >> > what is missing. >> >> > I don't know what a good solution is to cross platform development, >> >> > unless >> >> > everyone should produce code in all three platforms whenever they >> work >> >> > on a >> >> > patch or feature. >> >> > - Mohamed Mansour >> >> > >> >> > >> >> > On Sun, Aug 30, 2009 at 11:57 PM, Nico Weber <[email protected]> >> >> > wrote: >> >> >> >> >> >> Hi, >> >> >> >> >> >> I happened to look at a CL today that adds a "Really delete all >> >> >> passwords?" dialog on Windows ( >> http://codereview.chromium.org/155291 >> >> >> ). The patch was done by someone relatively new to the project >> (which >> >> >> is of course great). Sadly, neither the patch author nor one of the >> >> >> reviewers mentioned that this change might have to be done on the >> >> >> other platforms as well. As it happens, it's not necessary on OS X, >> >> >> but it might be required on Linux. >> >> >> >> >> >> What's out approach to make sure that such UI tweaks reach all >> >> >> platforms? Do we require that contributors who do a UI tweak >> implement >> >> >> it on all three platforms? Do we require that contributors who do >> such >> >> >> a change open bugs for the platforms they don't do the change on and >> >> >> hope someone else will do the change on the other platforms? Or do >> we >> >> >> simply not worry about this too much, as it doesn't happen that >> often >> >> >> anyway? >> >> >> >> >> >> Just curious. >> >> >> Nico >> >> >> >> >> >> >> >> > >> >> > >> >> > > >> >> > >> >> >> >> >> >> > >> > >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
