> Q: When I change src/DEPS, do I also have to change upstream > > third_party/WebKit/WebKit/chromium/DEPS? > > A: It depends why you update src/DEPS. Theoretically, you should only > update > > the upstream DEPS if the fix to the dependency actually changes the way > > webkit interacts with it, or fixes a bug in the webkit layout tests. > > However, if the change is only relevant to chromium, than webkit's DEPS > need > > not be updated. If that change breaks webkit, we will surely find it when > we > > build chromium. >
This seems like a mistake having out of sync rev may cause all sorts of issues. Here's a simple one suppose there is a rev that fixes some issue and adds an assert and it is only done in chromium. Now code is changed in webkit which would trigger this assert. This increases the pain for rolls and seems like a mistake. > > Q: Why don't we control webkit's dependencies in a single place? > > A: Most of the dependencies that webkit uses are also used directly by > > chromium. Therefore, we will often find ourselves rolling webkit > revisions > > just because chromium needs a third party revision update. We have been > > there once, it was painful, we don't want to go there again. > Why not just allow an override in chromium's deps file? This way if one really needs to change a rev without doing a webkit roll there is a way but ideally there would be one place where the deps are specified. Everytime there is duplicate information that may get out of sync and cause wierd errors, it increases the complexity of the system which is a bad thing. dave > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
