On Tue, Oct 6, 2009 at 9:21 AM, Jacob Mandelson <[email protected]> wrote: > I tried this, and it does indeed link far, far faster! > However, I got errors about RegisterInternalNaClPlugin(): > /mnt/sda4/media/contrib/chrome2/home/chrome-svn/tarball/chromium/src/sconsbuild/Debug/lib/librenderer.so: > undefined reference to `RegisterInternalNaClPlugin(bool (*)(int, int*))' > (Also one for libbrowser.so)
In general, the shared link breaks frequently. Whenever I work from a cafe or wherever from my laptop, I usually will do a TBR commit or two to fix the shared link. > I see these are protected by #ifndef DISABLE_NACL and > if (command_line.HasSwitch(switches::kInternalNaCl)), but why would that > affect things? DISABLE_NACL should be defined or not the same for shared > or static build, and the HasSwitch is a run-time check. If I comment them > out, then chrome links. But the call is in RenderProcess::RenderProcess(), > surely not dead code that the static link would be removing. > Any idea what's going on here? Perhaps NACL isn't yet working in the shared build. I think NACL is on now, so DISABLE_NACL should be undefined. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
