On Tue, Sep 22, 2009 at 6:06 PM, Dimitri Glazkov <[email protected]> wrote: > Today wasn't a happy day for p...@. He did a seemingly innocuous roll > that broke the world: selenium, ui tests, layout tests. I am sure it > was stressful and probably added unnecessary gray to his hair. >
> 2) writers of patches don't test them properly. In Paul's case, it was > http://trac.webkit.org/changeset/48639, again by a teammate, and it > looks like the patch wasn't very thoroughly tested -- it showed a few > regressions in the canary, but because it had to do with V8 garbage > collection, the failures were intermittent and seemingly random. > However, landing it on trunk looked like a shrapnel blast. Happened again today. Alpha (hclam@) was the most recent victim, along with the prolonged tree closure and sheriff-firefighting. Here's the perp: http://trac.webkit.org/changeset/49429. May I suggest a heaping of WebKit gardening duty as the preventive therapy? :DG< --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
