On Tue, Oct 13, 2009 at 8:21 AM, Adam Barth <[email protected]> wrote:
> On Tue, Oct 13, 2009 at 8:09 AM, David Levin <[email protected]> wrote: > > The webkit api won't help if chromium folks (especially when you change > v8 > > bindings) don't run the layout tests which is what happened yesterday and > > causes quite a few of our worst problems while gardening. > > I agree this is essential. > > > If you're changing the v8 bindings, you're doing it to fix a problem in > > chromium, so you must have a build of chomium (and thus be able to run > > layout tests). > > Eric is going to add commit-queue coverage for the V8 bindings, which > should help with this problem significantly. > I think this is a great addition, but shouldn't the canary bots have had just as much of a chance of catching this issue? Why didn't they catch it? Is it b/c of flakiness? If so, then try bots won't help that much. What I think we need to do is beef up the canary bots so that they provide equivalent coverage to the mainline Chromium bots. This will be essential if we ever wish to roll WebKit less often (once per week say), which will only really be possible once we have the WebKit API. -Darin > > Adam > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
