This might only apply to the media layout tests, but I'll give the heads up anyway... We found flakiness even when using load if the test is explicitly trying to test for stalled/progress/abort events before the load is completed: http://svn.webkit.org/repository/webkit/trunk/LayoutTests/media/video-error-abort.html What's happening is loadstart fires and the video reloads which should cause an abort event. For some reason load will occasionally fire after loadstart, ending the test.
I know we can patch the test, but I've been digging through the event dispatching code to verify that the flakiness isn't limited to Chromium. Andrew On Fri, Oct 9, 2009 at 8:16 PM, Amanda Walker <[email protected]> wrote: > Most awesome. Very good catch. > > On Fri, Oct 9, 2009 at 9:52 PM, Julie Parent <[email protected]> wrote: > >> For those of you looking into flaky tests - >> I've found a surprising number of tests that are flaky because they use a >> setTimeout to guarantee that a resource (usually an iframe) has loaded. >> This leads to slower running, flaky tests. To address this, change the >> tests upstream to use onload instead and make the world a better place :) >> I'm converting all of the editing tests now. >> >> Julie >> >> >> > > > -- > "Portability is generally the result of advance planning rather than trench > warfare involving #ifdef" -- Henry Spencer (1992) > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
