Another class of layout tests with bad setTimeouts in them -
Tests of the form:
<body onload="runTest();">
<img>
...
function runTest() {
// Wait for img to load
setTimeout(step2, 200);
}
These tests are not flaky, but the setTimeouts are completely
unnecessary (body onload always fires AFTER the img loads) and are just
leading to longer cycle times. If you encounter these, feel free to
eliminate the setTimeout and waitUntilDone calls.
Julie
On Tue, Oct 13, 2009 at 11:48 PM, Andrew Scherkus <scher...@chromium.org>wrote:
> On Tue, Oct 13, 2009 at 3:55 PM, Ojan Vafai <o...@chromium.org> wrote:
>
>> On Tue, Oct 13, 2009 at 3:50 PM, Andrew Scherkus
>> <scher...@chromium.org>wrote:
>>
>>> What's happening is loadstart fires and the video reloads which should
>>> cause an abort event. For some reason load will occasionally fire after
>>> loadstart, ending the test.
>>>
>>> I know we can patch the test, but I've been digging through the event
>>> dispatching code to verify that the flakiness isn't limited to Chromium.
>>>
>>
>> Even if it is just limited to Chromium, it is still a bug, right? Unless
>> I'm not understanding, there's no case under which we should be patching the
>> test in the above case. I don't know anything about video events, so I don't
>> really know what event order guarantees there should be.
>>
>> Ojan
>>
>
> Yeah it's has to be a bug somewhere, just tricky to track down due to the
> thread interaction between the video subsystem and the renderer thread.
>
> Andrew
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
