On Tue, Nov 17, 2009 at 11:16 AM, Elliot Glaysher (Chromium) <
e...@chromium.org> wrote:
> Currently, it only runs it at (gcl/git cl)
> upload time and only generates warnings. In the future, it should
> error at commit time, but I want to put this through a trial period so
> please pay attention to the warnings and yell and scream at me if
> there are false positives.
There are some unittests where we have super-long bits which go over 80
chars, and there are also some where the linter thinks our indenting is
strange when we do something like:
struct Foo { ... };
Foo foo_cases[] = {
{"a",
"b",
"c"},
}
(It doesn't like the uneven number of spaces when lining up the struct
member initializers).
I don't know whether those will trigger warnings/errors in your tool.
- ';' shouldn't be used in empty loops. Use "{}" instead.
>
This makes me super sad. ";" alone, indented, is so much more obvious.
PK
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
