[
https://issues.apache.org/jira/browse/CHUKWA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ari Rabkin updated CHUKWA-330:
------------------------------
Attachment: CHUKWA-330-big.patch
As best I understand, here's the best synethsis of what Eric and Jerome are
proposing.
- Adaptor.start() has been split into start() and parseArgs(). The parseArgs()
method parses the arguments, stores them, and returns only the part of the
argument that is required for duplicate detection -- so for instance, the
offset is not included. This is Eric's point about splitting mandatory from
optional params.
Only the mandatory part is used in synthesizing adaptor names by default. This
is basically jerome's suggestion, except without the hassle of maintaining a
registry.
I'm proposing this for trunk, not sure about 0.2
> controller should not create duplicates for adaptors with offsets
> -----------------------------------------------------------------
>
> Key: CHUKWA-330
> URL: https://issues.apache.org/jira/browse/CHUKWA-330
> Project: Hadoop Chukwa
> Issue Type: Bug
> Components: input tools
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Priority: Blocker
> Fix For: 0.2.0, 0.3.0
>
> Attachments: CHUKWA-330-big.patch, CHUKWA-330.patch
>
> Original Estimate: 1.5h
> Remaining Estimate: 1.5h
>
> The offset-of-first-byte param to FileTailingAdaptor is hashed into the
> default adaptor name. This changes the semantics of adaptor uniqueness, and
> broke metrics and the log4jappender.
> Proposed fix:
> Add a new "addByName()" method to ChukwaAgentController that lets callers
> specify names.
> Use this new method whenever finer control of adaptor uniqueness is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
