[
https://issues.apache.org/jira/browse/CHUKWA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723786#action_12723786
]
Jerome Boulon commented on CHUKWA-330:
--------------------------------------
or we can put back something similar to the simple check that was there before
for the 0.2 release + a check on the name.
But that one involved scanning all adaptors and may have some performances
impact under a large number of adaptors.
if (params.indexOf(a.getValue().getStreamName())!=-1) {
log.warn(params + " already exist, skipping.");
return null;
}
> controller should not create duplicates for adaptors with offsets
> -----------------------------------------------------------------
>
> Key: CHUKWA-330
> URL: https://issues.apache.org/jira/browse/CHUKWA-330
> Project: Hadoop Chukwa
> Issue Type: Bug
> Components: input tools
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Priority: Blocker
> Fix For: 0.2.0, 0.3.0
>
> Attachments: CHUKWA-330-big.patch, CHUKWA-330.patch
>
> Original Estimate: 1.5h
> Remaining Estimate: 1.5h
>
> The offset-of-first-byte param to FileTailingAdaptor is hashed into the
> default adaptor name. This changes the semantics of adaptor uniqueness, and
> broke metrics and the log4jappender.
> Proposed fix:
> Add a new "addByName()" method to ChukwaAgentController that lets callers
> specify names.
> Use this new method whenever finer control of adaptor uniqueness is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
