[ 
https://issues.apache.org/jira/browse/CHUKWA-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971747#action_12971747
 ] 

Bill Graham commented on CHUKWA-564:
------------------------------------

{quote}
1. Indirection mapping configuration is difficult to maintain on distributed 
system.
{quote}

I don't see how maintaining configs is more difficult than maintaining the same 
information in annotations. Both are doing the same thing and both need to be 
deployed to all nodes. The annotation approach is only different in that it 
requires new classes and compilation to change table and column family names 
from the defaults.

{quote}
2. Add extra overhead to the processor for lookup data routing.
{quote}
 
Again, I don't see how looking up the table/cf values for a processor from a 
Map for example (in the config case), is any more intensive than using 
reflection on a processor to see if it has certain annotations.

The issue of whether the ideal solution for a given use case is annotations or 
configs aside, it seems like both needs could be met if we made the lookup 
approach plugable via composition. The default implementation could fetch HBase 
schema info via annotations on processors as is done currently, but 
implementors would be free to implement the same interface differently using 
another approach. I can take a stab at the interface design if there are no 
objections.






> HBase output collector uses incorrect column family
> ---------------------------------------------------
>
>                 Key: CHUKWA-564
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-564
>             Project: Chukwa
>          Issue Type: Bug
>            Reporter: Bill Graham
>             Fix For: 0.5.0
>
>
> The HBase {{OutputCollector}} does this to obtain the column family from the 
> data type:
> {noformat}
> cf = key.getReduceType().getBytes();
> {noformat}
> The column family should instead be taken by the {[email protected]}} 
> annotation on the processor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to