That was my guess. :) Thanks for clarifying. We'll change that.
On Mon, Jun 20, 2011 at 3:15 PM, Jerome Boulon <[email protected]> wrote: > Yea, _JB_ should be changed to something else ;-) > That's something I may have done as a quick workaround ... > /Jerome > > On 6/20/11 2:52 PM, "Bill Graham (JIRA)" <[email protected]> wrote: > > > > > [ > > > https://issues.apache.org/jira/browse/CHUKWA-589?page=com.atlassian.jira.p > >lugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052241#com > >ment-13052241 ] > > > >Bill Graham commented on CHUKWA-589: > >------------------------------------ > > > >Looks good to me too although I'd like to request one more small change. > >In TestChukwaWriters you re-use the "testChukwaWriters_JB_" directory > >prefix used in the test data. Can you change that to something that > >implies the test name, so its content can be mapped to the test. > >Something like "testChukwaWriters_testSeqWriterFixedCloseInterval_". > > > >I'm not sure how the "_JB_" convention was introduced in the pre-existing > >test in that class (maybe Jerome's initials?), but you might a well > >correct that in the other test as well (i.e. > >"testChukwaWriters_testWriter_"). > > > >> Functionality allowing collectors to close .chukwa files at a fixed > >>offset inside the rotateInterval > >> > >>------------------------------------------------------------------------- > >>--------------------------- > >> > >> Key: CHUKWA-589 > >> URL: https://issues.apache.org/jira/browse/CHUKWA-589 > >> Project: Chukwa > >> Issue Type: New Feature > >> Components: data collection > >> Affects Versions: 0.5.0 > >> Reporter: Himanshu Gahlot > >> Attachments: CHUKWA-589_1.patch, CHUKWA-589_2.patch > >> > >> > >> We have a system built on top of Chukwa that introduces the need to > >>have all .chukwa files for a given rotateInterval closed and available > >>at a predictable time. Currently, we are experience some drift in the > >>times that the sequence files are closed due to the way the TimerTask is > >>scheduled in the SeqFileWriter class. We would like to submit a > >>solution that will allow people to configure the time all collectors > >>should close their files for processing in a given interval, while still > >>supporting the default functionality. > > > >-- > >This message is automatically generated by JIRA. > >For more information on JIRA, see: http://www.atlassian.com/software/jira > > > > > > > >
