try this patch? On Friday, May 21, 2021, Phyllis Smith via Cin <[email protected]> wrote:
> Andrew, > Also, forgot to mention that the file: 0001-constify-fileffmpeg.C.patch > although it includes re-enabled int video_probe line does NOT > include the av_frame_free(&frame); line as far as I can tell. > > On Mon, May 3, 2021 at 10:09 PM Andrew Randrianasulu via Cin < > [email protected]> wrote: > >> I think I spotted my error, resulting in memory leak.. >> >> Try to add >> >> av_frame_free(&frame); >> >> Just before return ret; line.. { line 1246 currently?} >> >> And after this re-enable line disabled in >> commit eabda9cf447580a974fd3d67a3d0a26f09aeb523 >> >> ff->video_probe(1); in fileffmpeg.C >> >> And of course re-test ( i probably loaded only very small project or >> number of files for noticing this.. :/) >> -- >> Cin mailing list >> [email protected] >> https://lists.cinelerra-gg.org/mailman/listinfo/cin >> >
From 1855b532a3a3bbff5ec9aab3ff1f10de55a12e2e Mon Sep 17 00:00:00 2001 From: Andrew Randrianasulu <[email protected]> Date: Fri, 21 May 2021 09:46:32 +0300 Subject: [PATCH] attempt to fix _probe function memory leak --- cinelerra-5.1/cinelerra/ffmpeg.C | 1 + 1 file changed, 1 insertion(+) diff --git a/cinelerra-5.1/cinelerra/ffmpeg.C b/cinelerra-5.1/cinelerra/ffmpeg.C index 55fa668e..96a5c385 100644 --- a/cinelerra-5.1/cinelerra/ffmpeg.C +++ b/cinelerra-5.1/cinelerra/ffmpeg.C @@ -1245,6 +1245,7 @@ int FFVideoStream::probe(int64_t pos) ret = -1; ret = ret > 0 ? 1 : ret < 0 ? -1 : 0; + av_frame_free(&frame); return ret; } -- 2.31.1
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
