On Saturday, August 7, 2021, Andrew Randrianasulu <[email protected]> wrote:
> > > On Saturday, August 7, 2021, Phyllis Smith via Cin < > [email protected]> wrote: > >> Andrew, more testing of "many tracks (armed/disarmed), many plugins, >> shared plugins, gang modes, etc...?" and it seems like a really good fix. >> Will wait to hear back from Andrea too. >> >> But there must be one more place that needs the same type of fix yet for >> GANG audio mode. This is currently working if you drag an audio plugin to >> a 2-channel audio track - that is, when you get back to regular mode you >> can see that the plugin is on both audio tracks. But when you have In/Out >> pointers and use the "attach effect" method instead, it only shows on the >> initial track. >> > > i tried to add two more lines into mwindowedit.C > > > and for me I can select in/out points for two gang modes where sound > tracks collapsed on timeline (with 6ch divx) and then use audio > attach > effect for inserting effect and it propagates correctly > apoarently this patch was invalid. but I played more with gang modes and effect attach to protected (unarmed) tracks and IMO there was bug If I attach effect in gang mode channels or media it will attach itself to all suitable channels, even unarmed! attached patch fix this, but i haven't tested for example two 6ch audio media on all different tracks.. > > >> >> Andrea, you have to have both patches in: in_out_selection.diff AND >> in_out_selection-2.diff . >> >> On Fri, Aug 6, 2021 at 10:14 AM Andrew Randrianasulu via Cin < >> [email protected]> wrote: >> >>> what about attached second patch? >>> >>> please also test main menu bar > video > atrach effect way.. >>> >>> >>> On Friday, August 6, 2021, Andrea paz <[email protected]> >>> wrote: >>> >>>> I confirm that the patch does not work. The In/Out points do not >>>> create a valid region for "attach effect". It works instead, as >>>> before, for the Drag&Drop effect from the Resources window. >>>> >>> -- >>> Cin mailing list >>> [email protected] >>> https://lists.cinelerra-gg.org/mailman/listinfo/cin >>> >>
From 767857b901a0bc712c51492e834ea84b9f9175f9 Mon Sep 17 00:00:00 2001 From: Andrew Randrianasulu <[email protected]> Date: Sat, 7 Aug 2021 07:00:28 +0300 Subject: [PATCH 4/4] Attempt at fixing armed status while attaching plugin in gang mode >0 --- cinelerra-5.1/cinelerra/track.C | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cinelerra-5.1/cinelerra/track.C b/cinelerra-5.1/cinelerra/track.C index aff2b093..86fbe834 100644 --- a/cinelerra-5.1/cinelerra/track.C +++ b/cinelerra-5.1/cinelerra/track.C @@ -1836,8 +1836,8 @@ int Track::in_gang(Track *track) int Track::is_armed() { -// return armed && gang_master()->armed; - return gang_master()->armed; + return armed && gang_master()->armed; +// return gang_master()->armed; } int Track::is_ganged() -- 2.32.0
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
