indeed, with this mod Histogram can recovery highlights ...
but again, I have no idea if it can work ok with this mode turned on
all the time, so maybe make it preference or conditional on rgb(a)
float?
On Wed, Nov 8, 2023 at 8:41 PM Andrew Randrianasulu
<randrianas...@gmail.com> wrote:
>
> or even like this, but histogram does not work sadly?
>
> will try to remove clamps from its code too, Like Andrea
>
> On Wed, Nov 8, 2023 at 8:26 PM Andrew Randrianasulu
> <randrianas...@gmail.com> wrote:
> >
> > with this HACK buffers can be overbright in X11/XV mode only, gl thrown
> > error!
> >
> >
> > On Wed, Nov 8, 2023 at 6:55 PM Andrew Randrianasulu
> > <randrianas...@gmail.com> wrote:
> > >
> > > On Wed, Nov 8, 2023 at 6:08 PM Andrew Randrianasulu
> > > <randrianas...@gmail.com> wrote:
> > > >
> > > > I tried cingg compiled on Nov, 1 2020 and issues still here - you need
> > > > native exr reader to see it with Andrea's sample. Either by
> > > > compositor's vectoroscope or color picker - in clipping case it will
> > > > show 1.0 for much of window area, in non-clipping mode (no plugins) it
> > > > will show up to 60.something in rgb channels!
> > > >
> > > > Sadly, 2018 version had no vectoroscope on compositor, need to
> > > > double-test if native exr reader + any plugin will fail there in the
> > > > same way via color picker.....
> > >
> > > so, may 6 2018 cingg exhibit same behavior on rgba-float tiff exported
> > > from cin-cv (because pure exr import somewhat not worked for me in
> > > this version).
> > >
> > > so, this is apparently not recent bug .....
diff --git a/cinelerra-5.1/plugins/histogram/histogram.C b/cinelerra-5.1/plugins/histogram/histogram.C
index c78c3c7c..975e2eab 100644
--- a/cinelerra-5.1/plugins/histogram/histogram.C
+++ b/cinelerra-5.1/plugins/histogram/histogram.C
@@ -234,7 +234,7 @@ float HistogramMain::calculate_level(float input, int mode, int use_value)
if( !EQUIV(config.gamma[mode], 0) ) {
output = pow(output, 1.0 / config.gamma[mode]);
- CLAMP(output, 0, 1.0);
+ //CLAMP(output, 0, 1.0);
}
// Apply value curve
@@ -247,7 +247,7 @@ float HistogramMain::calculate_level(float input, int mode, int use_value)
config.low_output[mode];
}
- CLAMP(output, 0, 1.0);
+ //CLAMP(output, 0, 1.0);
return output;
}
--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin
