On Saturday 23 September 2006 07:19, Pierre Marc Dumuid wrote:
> I have recently developed a patch that allows the display of the version
> info on startup, and in the preferences to hold info about the
> repository that the source was built from.  I haven't quite finished it
> yet but want to get feedback from package developers.
>
> The main idea is that:

I'd prefer a shorter option name, and only a single.

> ./configure --with-buildinfo-repotype=git
> ./configure --with-buildinfo-repotype=svn

--with-buildinfo=git
--with-buildinfo=svn

> Using this flag alone, it will only create / update the versioninfo.h
> file if it doesn't exist.  If you want it to be created on each compile,
> then you can pass the flag --with-buildinfo-recompile, which will force
> a re-creation of versioninfo.h on each execution of make, (and result in
> recompiling main.o and aboutprefs.o and re-linking)

--with-buildinfo=git/recompile
--with-buildinfo=svn/recompile

> +############# BUILDINFO display, (for displaying version / date)
> +AC_ARG_WITH(buildinfo-repotype,
> +          AC_HELP_STRING([--with-buildinfo-repotype], [sets the repository
> type (git or SVN at the moment) for build info]),

Maybe better:

[includes revision information in the 'About' box; allowed values: svn, git;
add /recompile to force rebuild on each make invocation]

> +if BUILDINFO_GIT
> +GITVERSION=$(shell if [ -d $(top_srcdir)/.git ]; then cd $(top_srcdir);
> cg-object-id; else echo "unk"; fi)

Don't rely on cogito, better:

git rev-parse HEAD

-- Hannes

_______________________________________________
Cinelerra mailing list
[email protected]
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra

Reply via email to