On Saturday 17 February 2007 17:03, [EMAIL PROTECTED] wrote:
> Hi,
>
> trying to compile cinelerra on amd64 / ubuntu edgy i had some problems
> i wanted to use ffmpeg from the repositories, same for x264.
>
> with attached patch,
>   * libmpeg3/video/mmxidct.S is only used on x86_32
>   * adds amd64 CFLAGS to use all amd64 features if configure is run with
>     --enable-mmx
>   * use libx264_pic if available instead of libx264 and if called
> with --with-pic

Thanks, but:

- There was talk recently that compilation fails on amd_64 
unless --enable-mmx=no. Your patch sets it to 'yes' if --enable-mmx was not 
set. I had to fix this particular problem. Has something changed? See
https://init.linpro.no/pipermail/skolelinux.no/cinelerra/2007-January/009702.html
http://repo.or.cz/w/cinelerra_cv.git?a=commitdiff;h=f7ca8d92e1c0cb0ef90cbc17506d388dd5cb0622
http://repo.or.cz/w/cinelerra_cv.git?a=commitdiff;h=052cb77e7d96c19ae260f696baa9d40c6e2313cc

- Is libx264_pic a commonly used name or specific to ubuntu?

- I'd like to move the x86_64 case above the powerpc case. Ok?

- Adding all those optimization options, -funroll-loops -minline-all-stringops 
etc. to the default compile line is a big NO-NO. It may be convenient for 
you, but it is not good practice in general. Is there any harm done if I 
remove them?

- You define an AM_CONDITIONAL named CPU_x86_64 that is not used anywhere. Ok 
to remove it?

- The assignment libx264_pic=yes must read libx264=yes. I'll fix that.

-- Hannes

_______________________________________________
Cinelerra mailing list
[email protected]
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra

Reply via email to