I've now had a closer look at this patch. On Saturday 17 February 2007 17:03, [EMAIL PROTECTED] wrote: > trying to compile cinelerra on amd64 / ubuntu edgy i had some problems > i wanted to use ffmpeg from the repositories, same for x264. > > with attached patch, > * libmpeg3/video/mmxidct.S is only used on x86_32
Your solution to this is unnecessary. It is patchwork; a workaround for a problem that your patch creates. Hint: Just because something's named USE_MMX it doesn't mean it must stay that way forever. > * adds amd64 CFLAGS to use all amd64 features if configure is run with > --enable-mmx It has been said that x86_64 does not equal amd64. And that adding optimization options unconditionally is not wanted. > * use libx264_pic if available instead of libx264 and if called > with --with-pic This part is ok, and I have applied it with some fixes (to my private repository only at the moment; I *will* publish that part). But the amd64 parts have been disputed too much, and if I listen to all voices, I need to strip out everything, which gets us back to square one. Furthermore, the patch is ... well ... patchwork; a clear sign of this is that you introduce yet another AM_CONDITIONAL(CPU_x86_32) just to protect something that is already protected by USEMMX... The patch needs a bit more work before I can accept it; please take care of the issues that have been brought up in this thread. -- Hannes _______________________________________________ Cinelerra mailing list [email protected] https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
