On Wednesday 07 March 2007 19:25, Christian Thaeter wrote: > > Remove the Garbage collector in favor of boost::shared_ptr, the GC has > > some nasty bugs, partially together with threads. By replacing ALL > > Asset* with boost::shared_ptr<Asset> these should be fixed on expanse of > > some performance.
Is boost::shared_ptr thread safe? If not, this replacement does not fix anything, in particular not the thread related bugs. > > Manage Assets in std::vector<boost::shared_ptr> / > > std::list<boost::shared_ptr>. > > First things done: > http://www.pipapo.org/gitweb?p=cinelerra/ct;a=shortlog;h=ct > you might pull it with git > git clone git://git.pipapo.org/git/cinelerra/ct > or > git clone git://repo.or.cz/cinelerra_cv/ct.git Replacing Asset* in parameter lists by Asset& is certainly not worth it. You gain absolutely nothing, but only introduce a lot of unnecessary code changes. Please don't do that. If you want to change something to use std:: classes, start by replacing strings (char*) by std::string. But don't do that in one big sweep, be very selective which strings you replace. Start with the text in the Titler plugin (that's a real bug). Work your way through topics, eg. path names (which are easily overflown), other strings that are user input. Finally, user interface strings like menu titles. (At least) for the latter use a typedef because these strings are likely to be promoted to Unicode strings to better support non-latin UI languages. -- Hannes _______________________________________________ Cinelerra mailing list [email protected] https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
