On Thu, 2005-02-24 at 01:33 -0800, Gerrit Huizenga wrote: > > > + if (!access_ok(VERIFY_READ, buf, count)) > > > + return -EFAULT; > > > + down(&(ri->vfs_inode.i_sem)); > > > + optbuf = kmalloc(TARGET_MAX_INPUT_SIZE, GFP_KERNEL); > > > > kmalloc with a lock held? Is that a good idea? > > Lock? Or sema? Sema should be okay here, right?
not if that semaphore can be grabbed from a file data write out path... and the semaphore sounds VFS-ish so it sure makes me nervous. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ ckrm-tech mailing list https://lists.sourceforge.net/lists/listinfo/ckrm-tech
