On Tue, 2005-09-20 at 18:20 +0900, MAEDA Naoaki wrote:
> Hi,
>
> Sorry to interrupt the discussion. I found a different rcfs
> mount/umount problem on f0.
>
> I tried to run the rapid mount/unmount script on f0, and then
> stopped the script by SIGINT. After that, I've sometimes observed
> that further rcfs mount request is failed by EPERM permanently.
>
> I guess the reason is that rcfs_mount_count is wrongly
> incremented in rcfs_fill_super() on error return case.
>
> Following patch fix the problem.
>
> Index: linux-2.6.13-ckrm/fs/rcfs/inode.c
> ===================================================================
> --- linux-2.6.13-ckrm.orig/fs/rcfs/inode.c
> +++ linux-2.6.13-ckrm/fs/rcfs/inode.c
> @@ -604,6 +604,8 @@ out_inode:
> sb->s_fs_info = NULL;
> iput(inode);
> out:
> + rcfs_mount_count--;
> +
> return rc;
> }
Wouldn't this also decrement the mount count in the non-error case? I
haven't looked into this region of the code to confirm, but perhaps
something like:
out:
if (rc)
rcfs_mount_count--;
Would be appropriate?
Cheers,
-Matt Helsley
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech
