On Wed, 2005-10-05 at 16:58 +0900, MAEDA Naoaki wrote:
> Hi Chandra,
> 
> I have a comment for the specification of the ckrm_register_res_ctlr()
> in f series CKRM core.
> 
> From an impression of the function name, it seems to register a resource
> controller with thier callbacks to the CKRM core and to do all related
> works, but the reality is that it doesn't set the resid field in the
> ckrm_res_ctlr structure passed to the function. Unless setting the resid
> field, the registered callback will be called with an illegal resource
> pointer.

Yes, it is supposed to work that way (code missed while moving from e
series to f series). 

We can put that in the same place as it is in e19.
> 
> Although the resid can be set by a resource controller side,
> this specification can misleads a resource controller writer.
> (At least, I was trapped :-P)
> 
> Could you consider to modify the specification to set the resid field
> by the ckrm_register_res_ctlr()? Or do you have a reason not to do that?
> 
> Thanks,
> MAEDA Naoaki
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Power Architecture Resource Center: Free content, downloads, discussions,
> and more. http://solutions.newsforge.com/ibmarch.tmpl
> _______________________________________________
> ckrm-tech mailing list
> https://lists.sourceforge.net/lists/listinfo/ckrm-tech
> 
-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - [EMAIL PROTECTED]   |      .......you may get it.
----------------------------------------------------------------------




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech

Reply via email to