Maeda-san,

On Tue, 11 Oct 2005 14:02:48 +0900
MAEDA Naoaki <[EMAIL PROTECTED]> wrote:

> > One generic comment, it will be better if you could separate the CKRM
> > functionality (most of your patch) to a separate file and place it in
> > the ckrm directory rather than adding to the cpr_rc.c file in the kernel
> > directory.
> 
> It requires some changes of Kurosawa-san's code structure to do so.
> I've never tried it, but at least struct cpu_rc_domain, struct cpu_rc
> and some static inline functions must be moved to cpu_rc.h.
> 
> Kurosawa-san, how do you think these changes against your code?
> Obviously this change may also affects your cpumeter interface code.

No problem for me.
But the problem is that people who don't know cpu_rc is also usable
for CKRM wouldn't think those changes were essential.

Thanks,
-- 
KUROSAWA, Takahiro


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech

Reply via email to