On Tue, 2006-01-17 at 10:57 +0900, KUROSAWA Takahiro wrote: > The pzone (pseudo zone) based memory resource controller is yet > another implementation of the CKRM memory resource controller. > The existing CKRM memory resource controller counts the number of > pages that are allocated for tasks in a class in order to guarantee > and limit memory resources. This requires changes to the existing > code for page allocation and page reclaim.
This is an interesting approach, and it may have some potential. First of all, to get better reviews, I'd suggest that you post your patches LKML-style: one per email. I remember myself wanting something like for_each_zone_in_node() recently. You might want to break that part of your patch out separately. In fact, there are quite a few small steps in your patches that should probably be made separate. There are also quite a few too many #ifdefs in .c files. You should work to reduce them. pzone_hold() and pzone_release() appear to be some pretty generic "keep the number of nodes the same for now" locks. These would proabably make a decent standalone patch. 'lock/unlock_nr_zones()' might be more appropriate names. I was temped to create something like this for memory hotplug, but never went to all of the trouble that you did. It could be very helpful. I only have a vague notion of which places in the kernel are suitable for a pzone and which are suitable for a real zone. Making that more obvious would be helpful. I'm not sure that pzone and zone should really share a structure. Zones are really contiguous sets of physical memory, and pzones appear to be significantly different. For instance, why should a pzone have a spanned_pages? Does that make sense? You may want to take a subset of the normal 'struct zone' attributes like the free lists, and move them into a 'mini-zone' structure. That would be a structure that 'struct zone' and a potential 'struct pzone' could share. -- Dave ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ ckrm-tech mailing list https://lists.sourceforge.net/lists/listinfo/ckrm-tech
