On Mon, 16 Jan 2006 18:13:17 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote:
> I remember myself wanting something like for_each_zone_in_node() > recently. You might want to break that part of your patch out > separately. In fact, there are quite a few small steps in your patches > that should probably be made separate. Thanks for the comments. I'll split out some generic macros as separate patches. > pzone_hold() and pzone_release() appear to be some pretty generic "keep > the number of nodes the same for now" locks. These would proabably make > a decent standalone patch. 'lock/unlock_nr_zones()' might be more > appropriate names. I was temped to create something like this for > memory hotplug, but never went to all of the trouble that you did. It > could be very helpful. Yes, memory management code in Linux takes the number of zones as static. That's one of the most painful point of pzones. Anyway, I'm glad to find another potential user of pzone_hold or lock_nr_zones :-) > I'm not sure that pzone and zone should really share a structure. Zones > are really contiguous sets of physical memory, and pzones appear to be > significantly different. For instance, why should a pzone have a > spanned_pages? Does that make sense? > > You may want to take a subset of the normal 'struct zone' attributes > like the free lists, and move them into a 'mini-zone' structure. That > would be a structure that 'struct zone' and a potential 'struct pzone' > could share. That's right. Introducing a structure like mini-zone would be a sane approach. I tried to introduce such a structure, but noticed that so many modifications would be needed. I'd like to show how few modifications are needed for the existing code. So, as a first step, I took the approach like the current pzone. -- KUROSAWA, Takahiro ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ ckrm-tech mailing list https://lists.sourceforge.net/lists/listinfo/ckrm-tech
