Matt Helsley wrote: > On Thu, 2006-11-02 at 12:08 +0300, Pavel Emelianov wrote: >> [snip] >> >>> I think that having a "tasks" file and a "threads" file in each >>> container directory would be a clean way to handle it: >>> >>> "tasks" : read/write complete process members >>> "threads" : read/write individual thread members >> I've just thought of it. >> >> Beancounter may have more than 409 tasks, while configfs >> doesn't allow attributes to store more than PAGE_SIZE bytes >> on read. So how would you fill so many tasks in one page? > > To be clear that's a limitation of configfs as an interface. In the > Resource Groups code, for example, there is no hard limitation on length > of the underlying list. This is why we're talking about a filesystem > interface and not necessarily a configfs interface.
David Rientjes persuaded me that writing our own file system is reimplementing the existing thing. If we've agreed with file system interface then configfs may be used. But the limitations I've pointed out must be discussed. Let me remind: 1. limitation of size of data written out of configfs; 2. when configfs is a module user won't be able to use beancounters. and one new 3. now in beancounters we have /proc/user_beancounters file that shows the complete statistics on BC. This includes all then beancounters in the system with all resources' held/maxheld/failcounters/etc. This is very handy and "vividly": a simple 'cat' shows you all you need. With configfs we lack this very handy feature. >> I like the idea of writing pids/tids to these files, but >> printing them back is not that easy. > > That depends on how you do it. For instance, if you don't have an > explicit list of tasks in the group (rough cost: 1 list head per task) > then yes, it could be difficult. I propose not to have the list of tasks associated with beancounter (what for?) but to extend /proc/<pid>/status with 'bcid: <id>' field. /configfs/beancounters/<id>/(tasks|threads) file should be write-only then. What do you think? ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ ckrm-tech mailing list https://lists.sourceforge.net/lists/listinfo/ckrm-tech
