On Fri, Apr 06, 2007 at 04:32:24PM -0700, [EMAIL PROTECTED] wrote:
> +struct container_subsys {
> +     int (*create)(struct container_subsys *ss,
> +                   struct container *cont);
> +     void (*destroy)(struct container_subsys *ss, struct container *cont);
> +     int (*can_attach)(struct container_subsys *ss,
> +                       struct container *cont, struct task_struct *tsk);
> +     void (*attach)(struct container_subsys *ss, struct container *cont,
> +                     struct container *old_cont, struct task_struct *tsk);
> +     void (*fork)(struct container_subsys *ss, struct task_struct *task);
> +     void (*exit)(struct container_subsys *ss, struct task_struct *task);
> +     int (*populate)(struct container_subsys *ss,
> +                     struct container *cont);
> +     void (*bind)(struct container_subsys *ss, struct container *root);

Is the first argument into all the callbacks, struct container_subsys *ss,
necessary?

> +struct container_subsys cpuset_subsys = {
> +     .name = "cpuset",
> +     .create = cpuset_create,
> +     .destroy  = cpuset_destroy,
> +     .can_attach = cpuset_can_attach,
> +     .attach = cpuset_attach,
> +     .populate = cpuset_populate,
> +     .subsys_id = cpuset_subsys_id,
> +     .early_init = 1,
> +};

We seem to be missing a register call here as well ..

-- 
Regards,
vatsa

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech

Reply via email to