On Jul 30, 2005, at 07:23 AM, Tomasz Kojm wrote:
On Fri, 29 Jul 2005 15:31:52 -0700 James Paige <[EMAIL PROTECTED]> wrote:Dale Walsh wrote:On Jul 29, 2005, at 04:45 PM, Tomasz Kojm wrote:On Fri, 29 Jul 2005 16:23:57 -0400 Dale Walsh <[EMAIL PROTECTED]> wrote:I've already linked against 0.13.38 and it doesn't appear to have anyill effects on libclamav so maybe what is in 0.13.38 is compatible with the fixes you implemented in 0.10.27.No, it isn't. Please read the sources and hopefully you will understandwhat I was talking about.I's catching viruses and doesn't look like there are any problems..I have no time to explain in which cases your compilation will fail.-- oo ..... Tomasz Kojm <[EMAIL PROTECTED]>Tomasz, can I get a diff on the changes you implemented in zziplib please?-- DaleI know Tomasz is a busy man ;) but if he remembers which version ofzziplib was originally forked for inclusion in clamav, it would not bedifficult for one of us to create the diff.The current zziplib code in libclamav is based on 0.12.83 -- oo ..... Tomasz Kojm <[EMAIL PROTECTED]>
I've generated a diff against the original zziplib you stated. I'm curious why you commented out the realdir stuff??Is there a problem having this function that CLamAV doesn't like or was it just to reduce it to used functions??
In it's entirety, zzip uses libzip but you don't seem to use this library or the libzzip-seek functions.
0.13.38 is a little more complex in nature, I'll look into it further but so far I haven't experienced any issues with using an external zziplib and the only other solution I can see to avoid the zziplib conflict would be to build the intenal zziplib as an external libclamav-zzip and have libclamav link against it solving library conflicts.
I'll look further into it.
-- Dale
PS.
in case anyone else is interested, here's the diff on the zziplib.
libclamav_zziplib.diff
Description: Binary data
_______________________________________________ http://lurker.clamav.net/list/clamav-devel.html
