On Wed, 28 Feb 2007 22:19:50 +0100 Gianluigi Tiesi <[EMAIL PROTECTED]> wrote:
> > I think you're still missing the point of this discussion. And the point > > is that changing the line 233 of libclamav/filetypes.c to > > "if(!(iscntrl(buf[i]) || isprint(buf[i])) || !internat[buf[i] & xff])" > > you seriously broke the detection. That's all and the rest is off-topic. > > > I agree with you about the OT, but still not agree about the code, > we have scanned 1gb of various malware (all types also non ext) > detected by clamav or not, and there was no false negatives in the scan. > I've seen in svn it was commented, so yes better to leave it out ;) > If you find some serious possible false negative problem, please > tell me so I will be happy to remove the code. Any international text that includes character(s) from range [0x80..0xff] will be misclassified as CL_TYPE_UNKNOWN_DATA with your version of the line 233. Please respect our time, I really spent too much time today explaining this issue. -- oo ..... Tomasz Kojm <[EMAIL PROTECTED]> (\/)\......... http://www.ClamAV.net/gpg/tkojm.gpg \..........._ 0DCA5A08407D5288279DB43454822DC8985A444B //\ /\ Wed Feb 28 22:20:27 CET 2007 _______________________________________________ http://lurker.clamav.net/list/clamav-devel.html Please submit your patches to our Bugzilla: http://bugs.clamav.net
