On Wed, 2005-06-01 at 18:30 -0400, Thomas Fitzsimmons wrote: > > /** > > * This is an old method, no idea if it's correct. > > */ > > private int[] convertPixels (byte[] pixels) > > Can this comment be removed?
Only if you can confirm the method is correct. I'm still not sure it is. It's just what the old code did. > > /* functions used by other gtk peer native routines */ > > GdkPixbuf *gnu_java_awt_peer_gtk_GtkImage_getPixbuf(JNIEnv *env, jobject > > obj); > > GdkPixmap *gnu_java_awt_peer_gtk_GtkImage_getPixmap(JNIEnv *env, jobject > > obj); > > jboolean gnu_java_awt_peer_gtk_GtkImage_isOffScreen(JNIEnv *env, jobject > > obj); > > Typically we declare functions used by multiple peers in gtkpeer.h. Is > it necessary to use these long JNI-style names? Ah. Well, these are only used in 2 places, but I can move them, sure. As for the long style names, it's not necessary of course, I just wanted to follow the convention. Maybe it should be shortened to just GtkImage_* instead. (Including the class name seems like a good idea to me, since it indicates what kind of class obj is intended to be, and where the function is located.) /Sven _______________________________________________ Classpath-patches mailing list [email protected] http://lists.gnu.org/mailman/listinfo/classpath-patches
