Actually I think they look fine this way - a line break is needed anyway...
I worry that if we place significant information in the CVS metadata it could get lost if, for example, Classpath were to switch source control systems in the future. For that matter, at least gcj and Kaffe keep copies of Classpath in their own CVS/svn repositories which would also need the flag set. And we'd need to remember to set it on the generics branch next time a merge is done. Bypassing the problem entirely by simply formatting the string differently in the source code seems like a better deal to me. Another alternative would be to replace one or both of the $ signs with the equivalent \uXXXX unicode escape, but I think the way the patch does it now is more readable than that would be. I don't feel particularly strongly about it though. If there's a consensus that disabling keywords and writing the string directly would be better, then by all means let's do that instead. Stuart. On 2/10/06, Michael Koch <[EMAIL PROTECTED]> wrote: > On Fri, Feb 10, 2006 at 02:50:32PM -0500, Stuart Ballard wrote: > > RTFP ;) > > hmmm, you are right. I would prefer the disbaled to make at least the > definition of these evil constants look good. > > > Cheers, > Michael > -- > Escape the Java Trap with GNU Classpath! > http://www.gnu.org/philosophy/java-trap.html > > Join the community at http://planet.classpath.org/ > -- http://sab39.dev.netreach.com/
