Hi Keith, On Thu, 2006-02-16 at 14:21 -0800, Keith Seitz wrote: > Another pretty simple one. VirtualMachineCommandSet.executeIDsizes was > really jumping through hoops because JdwpID.size was abstract. Fooey. > This patch makes size() a static method and includes all the necessary > changes in other files.
Except in the VMFrame case (since that might change per VM, although just stating that it is always 8 seems also fine to me) it looks cleaner to make this static final int fields. e.g: static final int SIZE = 8; That is just my personal preference though. Small style nitpicks: > +//import gnu.classpath.jdwp.VMField; > +import gnu.classpath.jdwp.VMFrame; > +//import gnu.classpath.jdwp.VMMethod; Please add "FIXME, not yet implemented" or something similar to such uncommented code. > + os.writeInt(VMFrame.size ()); // frameId > [...] > + public static int size () Both method invocation and method declaration don't have a space between the method name and the opening bracket. This is different from the C coding style guide (and not always followed in all our code...) No biggies though. Cheers, Mark
signature.asc
Description: This is a digitally signed message part
