Hi,

On Thu, 2006-03-02 at 15:36 -0500, Lillian Angel wrote:

> 2006-03-02  Lillian Angel <[EMAIL PROTECTED]>
> 
>         * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c
>         (Java_gnu_java_awt_peer_gtk_GtkMenuPeer_delItem): Changed to
>         use the submenu to get the list of children. This now works
>         in the same way as addItem.

Looks great, except:

-
+  GtkMenu *menu;
+  
   gdk_threads_enter ();
 
   ptr = NSA_GET_PTR (env, obj);
 
-  list = gtk_container_get_children (GTK_CONTAINER (ptr));
+  menu = GTK_MENU (gtk_menu_item_get_submenu(GTK_MENU_ITEM(ptr)));

you should declare menu to be a GtkWidget* instead of a GtkMenu* and
remove the GTK_MENU cast.  GTK convention is to always use widgets and
downcast when necessary.

Tom



Reply via email to