Re: [cp-patches] Patch: GtkMenuPeer fix

[Lillian Angel]

On Thu, 2006-03-02 at 17:20 -0500, Thomas Fitzsimmons wrote:

> you should declare menu to be a GtkWidget* instead of a GtkMenu* and
> remove the GTK_MENU cast.  GTK convention is to always use widgets and
> downcast when necessary.


Good to know. Fixed.

2006-03-02  Lillian Angel <[EMAIL PROTECTED]>

        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c
        (Java_gnu_java_awt_peer_gtk_GtkMenuPeer_delItem): Fixed
        to use GtkWidget instead of GTKMenu.


Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c
===================================================================
RCS file: /sources/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c,v
retrieving revision 1.21
diff -u -r1.21 gnu_java_awt_peer_gtk_GtkMenuPeer.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c	2 Mar 2006 20:32:14 -0000	1.21
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c	2 Mar 2006 22:27:15 -0000
@@ -160,13 +160,13 @@
 {
   void *ptr;
   GList *list;
-  GtkMenu *menu;
+  GtkWidget *menu;
   
   gdk_threads_enter ();
 
   ptr = NSA_GET_PTR (env, obj);
 
-  menu = GTK_MENU (gtk_menu_item_get_submenu(GTK_MENU_ITEM(ptr)));
+  menu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(ptr));
 
   list = gtk_container_get_children (GTK_CONTAINER (menu));
   list = g_list_nth (list, index);