Hi Casten, On Fri, 2006-03-24 at 23:52 +0100, Carsten Neumann wrote: > I've implemented the method: public boolean isActive().
Nice. Useful method also. Last time I worked with the DefaultCaret I was
confused there wasn't such a method. I see this was added in 1.5. Could
you add a @since 1.5.
> Please also note that my copyright assignment is pending, but the
> process has been started.
Please send a ping (reply to this message on the list) when that is done
so we don't forget.
Just one tiny nitpick.
+ if(blinkTimer != null)
+ return blinkTimer.isRunning();
if normally has a space after it:
if (blinkTimer != null)
Although I admit that this is not always precisley followed. But please
see http://www.gnu.org/software/classpath/docs/hacking.html#SEC6
Seeing you followed the other guidelines there I assume you have read
that already :)
Thanks,
Mark
signature.asc
Description: This is a digitally signed message part
