On Sun, Mar 26, 2006 at 04:08:30PM +1100, Raif S. Naffah wrote:

> +# -* bash *-
> +
> +java gnu.classpath.tools.jarsigner.Main $@

You should add a a shebang line to this file:

#!/bin/sh

The questions is if we should hardcode "java" or better check for a java
executable in configure.ac and use $(JAVA) in the script.


> Index: configure.ac
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/configure.ac,v
> retrieving revision 1.139
> diff -u -r1.139 configure.ac
> --- configure.ac      10 Mar 2006 01:36:10 -0000      1.139
> +++ configure.ac      26 Mar 2006 04:59:44 -0000
> @@ -248,6 +248,8 @@
>  AC_PROG_CC
>  AC_PROG_CPP
> 
> +AC_PATH_PROGS(BASH, bash sh)

I think we can depend on the fact that a posix compatible shell is
installed on the system when configure can be run. And there is no need
to depend on bash. We need no bashisms.

BTW: Its good that you start this discussion now as I soon want to
import my policytool replacement. ;-)


Cheers,
Michael
-- 
http://www.worldforge.org/

Reply via email to