On 08:34 Mon 12 Apr , Ivan Maidanski wrote: > > Sun, 11 Apr 2010 20:46:29 +0100 Andrew John Hughes <ahug...@redhat.com>: > > > On 13:26 Fri 09 Apr , Ivan Maidanski wrote: > > > ... > > > > > > > > > > * examples/gnu/classpath/examples/swing/Demo.java (mkMenuBar): > > > > > Pass an empty class array instead of null to getMethod() (to > > > > > suppress > > > > > a warning). > > > > > > > > I think the correct fix here is to not pass a second argument but would > > > > need to check. > > > > > > I though about this variant but chose just to preserve conformance with > > > JLS 2.0. Of course, there is no principal difference between these 2 ways > > > for me (and, probably, anyone else). > > > > The codebase requires 1.5 anyway, so I'd prefer the cleaner approach > > without the additional argument was used. > > > > > > > > > The other changes look fine. > > Ok. I've changed the patch (attached) and the Changelog entries: > > * examples/gnu/classpath/examples/swing/Demo.java (mkMenuBar): > Don't pass null as a second argument to getMethod() (to suppress > a warning). > * resource/gnu/javax/print/PrinterDialog.properties: Rename to > "MessagesBundle.properties" (to prevent class name collision > in case the properties file is converted to a class). > * resource/gnu/javax/print/PrinterDialog_de.properties: Likewise. > * gnu/javax/print/PrinterDialog.java (messages): Get resources from > "gnu.javax.print.MessagesBundle" bundle instead of > "gnu/javax/print/PrinterDialog" one. > * tools/gnu/classpath/tools/common/Messages.java (BUNDLE_NAME): > Convert "gnu.classpath.tools.common.Messages" to lowercase (to be > consistent with other tools resource bundle names and to prevent class > name collision in case the properties file is converted to a class). > * tools/resource/gnu/classpath/tools/common/Messages.properties: > Rename to "messages.properties". > * tools/resource/gnu/classpath/tools/getopt/Messages.properties: > Likewise. > * > testsuite/javax.swing.text.html.parser/test/gnu/javax/swing/text/html/parser/Parser_Test.java: > Rename "enum" local variable to "en". > * > testsuite/javax.swing.text.html.parser/test/gnu/javax/swing/text/html/parser/ParserTest.java: > Likewise. >
I've committed this. I don't know how you managed to build it as tools/Makefile.am was not being updated with the new message bundle filenames. I fixed this before commit. > > If I understood correctly from your other letter, I could send the other > patches to the mentioned email (with CC to you) for reviewing right now w/o > waiting for the copyright assignment. Let me: 1. not resend this one to > classpath-patches@gnu.org (as it's already reviewed); 2. send every time only > one patch waiting for the reaction of the community and you. > > Bye. > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
