Hi, Pekka! Some issues to be corrected in you patch:
1. currentTimeMillis() should be renamed to currentTimeMicros() as it returns microseconds (not milliseconds). 2. clock_gettime(CLOCK_MONOTONIC) may fail on some machines (even if _POSIX_MONOTONIC_CLOCK has been defined during compilation), so IMHO it's better to silently fall-back to gettimeofday() in that case. Regards. Wed, 27 Oct 2010 22:41:27 +0400 Ivan Maidanski <iv...@mail.ru>: > Hi, Pekka! > > I remember your patch sent a month ago. As I already learned, the Gnu guys are > very serious about copyrights (as well as they are busy with other projects, > and not to mention there is little interest to this project from the community > since OpenJDK emerged). You mentioned that the patch code has been borrowed > from Japhar's. Did you get the sign-off from Chris Toshok to put this code > into this project? (And have you signed the FSF disclaimer paper?) > > Tue, 26 Oct 2010 23:06:14 +0300 Pekka Enberg <penb...@kernel.org>: > > > On 26.10.2010 23.00, Pekka Enberg wrote: > > > Hi everyone, > > > > > > I'm now carrying this and one other patch in my github branch: > > > > > > http://github.com/penberg/classpath/tree/maint/penberg > > Hmm I see only one (this) patch there. > > > > > > > It's frustrating that CVS trunk doesn't build out of the box > > What do you mean? Any patch improving the issue? > > > > and that > > > reviewed patches are not getting merged. :( > > Yes. I feel the same... Is there a way to solve the problem? I don't think > it is good to have another repository but it might turn out to be the only way > :( > > > Oops, here's the correct URL: > > http://github.com/penberg/classpath > > Pekka
