On Sun, 21 Nov 2010, Ivan Maidanski wrote:
Some issues to be corrected in you patch:

1. currentTimeMillis() should be renamed to currentTimeMicros() as it returns 
microseconds (not milliseconds).

2. clock_gettime(CLOCK_MONOTONIC) may fail on some machines (even if 
_POSIX_MONOTONIC_CLOCK has been defined during compilation), so IMHO it's 
better to silently fall-back to gettimeofday() in that case.

I sent a follow-up patch to fix those. I don't have GNU copyright assignment papers signed. Is that a problem? If so, I'm happy to do the paperwork if someone points me to the right direction.

                        Pekka

Reply via email to