Tom Tromey wrote:
> Bryce> I merged the ThreadGroup classes from libgcj and classpath.
>
> Thanks Bryce.
>
> Bryce> The result should be cleaner and have less bugs then either of
> Bryce> its ancestors (I noticed various different bugs in both
> Bryce> versions while working on it).
>
> I like to hear things like this.
>
> One note. Currently you use the libgcj header for the file. I
> recommend following the Classpath style instead.
I actually like the libgcj style better, its more concise. There is a very
large number of classes in classpath/libgcj that are actually very small,
consisting of maybe 10 or less lines of code (think exception classes,
etc). In these cases I find it a bit annoying to have a 25 line copyright
header followed by just a few lines of code.
Over the course of 1000 or so source files, the size of these headers also
becomes considerable (1MB or more).
Is there a legal requirement to have the verbose header, or could we settle
on a new, more concise header like the libgcj one?
regards
[ bryce ]
